Skip to content

feat: add GuideContextDetails to guide toolbar v2#870

Merged
thomaswhyyou merged 5 commits intomainfrom
thomas-kno-11142-sdk-guide-toolbar-v2-poc-10
Feb 19, 2026
Merged

feat: add GuideContextDetails to guide toolbar v2#870
thomaswhyyou merged 5 commits intomainfrom
thomas-kno-11142-sdk-guide-toolbar-v2-poc-10

Conversation

@thomaswhyyou
Copy link
Contributor

@thomaswhyyou thomaswhyyou commented Feb 19, 2026

Description

A few small UI updates:

  • Add only-displaying vs only-displayable display option
  • Add GuideContextDetails.tsx to surface the current target params and throttle settings

Screenshots or videos

CleanShot.2026-02-18.at.19.32.37.mp4

@linear
Copy link

linear bot commented Feb 19, 2026

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2026

🦋 Changeset detected

Latest commit: 56dde68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@knocklabs/react Patch
guide-example Patch
@knocklabs/client Patch
@knocklabs/react-core Patch
ms-teams-connect-example Patch
nextjs-app-dir-example Patch
nextjs-example Patch
slack-connect-example Patch
slack-kit-example Patch
client-example Patch
@knocklabs/expo Patch
@knocklabs/react-native Patch
@knocklabs/expo-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Feb 19, 2026 9:39pm
javascript-nextjs-example Ready Ready Preview, Comment Feb 19, 2026 9:39pm
javascript-slack-connect-example Ready Ready Preview, Comment Feb 19, 2026 9:39pm
javascript-slack-kit-example Ready Ready Preview, Comment Feb 19, 2026 9:39pm

Request Review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

>
{orderIndex + 1}
</Tag>
<Text as="code" size="1">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guide key text lost active/inactive color distinction

Medium Severity

The color prop (color={guide.active ? "black" : "disabled"}) was dropped from the Text component rendering guide.key during the refactor that moved GuideHoverCard to wrap the entire row. This removes the visual distinction between active and inactive guide keys. The rest of the component still uses guide.active for styling (e.g., green/red button color), so this looks like an accidental omission.

Fix in Cursor Fix in Web

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, intentional.

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 9.34579% with 97 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.13%. Comparing base (681b7fa) to head (56dde68).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...uide/components/Toolbar/V2/GuideContextDetails.tsx 7.69% 72 Missing ⚠️
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 0.00% 11 Missing ⚠️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 9.09% 10 Missing ⚠️
.../components/Toolbar/V2/GuidesListDisplaySelect.tsx 0.00% 3 Missing ⚠️
...les/guide/components/Toolbar/V2/GuideHoverCard.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   67.90%   67.13%   -0.77%     
==========================================
  Files         204      205       +1     
  Lines        8767     8888     +121     
  Branches     1183     1183              
==========================================
+ Hits         5953     5967      +14     
- Misses       2790     2901     +111     
+ Partials       24       20       -4     
Files with missing lines Coverage Δ
...omponents/Toolbar/V2/useInspectGuideClientStore.ts 100.00% <100.00%> (ø)
...les/guide/components/Toolbar/V2/GuideHoverCard.tsx 10.63% <0.00%> (ø)
.../components/Toolbar/V2/GuidesListDisplaySelect.tsx 12.50% <0.00%> (-1.14%) ⬇️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 15.15% <9.09%> (+0.25%) ⬆️
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 8.59% <0.00%> (ø)
...uide/components/Toolbar/V2/GuideContextDetails.tsx 7.69% <7.69%> (ø)

... and 11 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments