Skip to content

Conversation

@thomaswhyyou
Copy link
Contributor

@thomaswhyyou thomaswhyyou commented Feb 2, 2026

Description

  • Implements the first set of guide "annotation"s in useInspectGuideClientStore, which is used by the toolbar to surface various guide statuses for debugging purposes.
  • In this PR, we only focus on eligibility statuses (active, archived, targetable statuses)
  • Adds GuidesList to show a list of guides with its eligibility statuses
  • Adds GuidesListDisplaySelect to filter the list based on eligibility statuses
  • Adds GuideHoverCard that shows individual guide's payload from the guide client state store

Screenshots or videos

CleanShot.2026-02-12.at.10.47.26.mp4

@linear
Copy link

linear bot commented Feb 2, 2026

@vercel
Copy link

vercel bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Feb 13, 2026 1:51am
javascript-nextjs-example Ready Ready Preview, Comment Feb 13, 2026 1:51am
javascript-slack-connect-example Ready Ready Preview, Comment Feb 13, 2026 1:51am
javascript-slack-kit-example Ready Ready Preview, Comment Feb 13, 2026 1:51am

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2026

⚠️ No Changeset found

Latest commit: 4a41c9b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-5 branch from 968d4b2 to ac879d5 Compare February 2, 2026 20:10
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-6 branch from 89d2bfa to a415e75 Compare February 2, 2026 20:10
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-5 branch from ac879d5 to 84f9e9e Compare February 2, 2026 21:34
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-6 branch from a415e75 to b5369e6 Compare February 2, 2026 21:34
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-5 branch from 84f9e9e to 0ebc110 Compare February 3, 2026 19:09
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-6 branch from b5369e6 to 0a38e96 Compare February 3, 2026 19:09
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 46.80851% with 150 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.34%. Comparing base (1b09589) to head (4a41c9b).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 13.25% 72 Missing ⚠️
...les/guide/components/Toolbar/V2/GuideHoverCard.tsx 10.63% 42 Missing ⚠️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 20.83% 19 Missing ⚠️
.../components/Toolbar/V2/GuidesListDisplaySelect.tsx 15.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #846      +/-   ##
==========================================
- Coverage   67.97%   67.34%   -0.64%     
==========================================
  Files         199      203       +4     
  Lines        8194     8461     +267     
  Branches     1075     1101      +26     
==========================================
+ Hits         5570     5698     +128     
- Misses       2599     2738     +139     
  Partials       25       25              
Files with missing lines Coverage Δ
packages/client/src/clients/guide/index.ts 100.00% <ø> (ø)
packages/client/src/clients/guide/types.ts 100.00% <ø> (ø)
...omponents/Toolbar/V2/useInspectGuideClientStore.ts 100.00% <100.00%> (ø)
...act/src/modules/guide/components/Toolbar/shared.ts 100.00% <100.00%> (ø)
.../components/Toolbar/V2/GuidesListDisplaySelect.tsx 15.00% <15.00%> (ø)
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 15.90% <20.83%> (+0.52%) ⬆️
...les/guide/components/Toolbar/V2/GuideHoverCard.tsx 10.63% <10.63%> (ø)
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 13.25% <13.25%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants