-
Notifications
You must be signed in to change notification settings - Fork 14
chore: handle ineligible_guides in guides fetch response #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: thomas-kno-11142-sdk-guide-toolbar-v2-poc-1
Are you sure you want to change the base?
chore: handle ineligible_guides in guides fetch response #844
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
3ca6b2e to
bfd9122
Compare
9c6bd46 to
34821df
Compare
34821df to
7963ad8
Compare
|
@cursor review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## thomas-kno-11142-sdk-guide-toolbar-v2-poc-1 #844 +/- ##
==============================================================================
Coverage ? 68.45%
==============================================================================
Files ? 193
Lines ? 8052
Branches ? 1066
==============================================================================
Hits ? 5512
Misses ? 2515
Partials ? 25
|
|
@cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR

Description
This PR updates the guide client so it reads
ineligible_guidesfrom the fetch endpoint response and stores into the client state store, to prep ahead of the toolbar changes in downstream PRs.As a reminder, this new field was introduced recently (here) to expose "ineligible markers", a minimal payload that explains which guide was evaluated ineligible for what reason. This information was previously inaccessible to the outside callers, but we want to surface it in the guide toolbar.