test: update llvm ir expectations for autodiff tests when dlopen #149986
+42
−55
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,7 @@ fn square(x: &f32) -> f32 { | |
| } | ||
|
|
||
| // d_square2 | ||
| // CHECK: define internal {{[ a-z_]*}} [4 x float] @fwddiffe4square({{[ a-z0-9()_]*}} %x{{.*}}, [4 x ptr] %"x'") | ||
| // CHECK-NEXT: start: | ||
| // CHECK-NEXT: %0 = extractvalue [4 x ptr] %"x'", 0 | ||
| // CHECK-NEXT: %"_2'ipl" = load float, ptr %0, align 4 | ||
|
|
@@ -33,28 +33,23 @@ fn square(x: &f32) -> f32 { | |
| // CHECK-NEXT: %"_2'ipl2" = load float, ptr %2, align 4 | ||
| // CHECK-NEXT: %3 = extractvalue [4 x ptr] %"x'", 3 | ||
| // CHECK-NEXT: %"_2'ipl3" = load float, ptr %3, align 4 | ||
| // CHECK-NEXT: %4 = fadd fast float %"_2'ipl", %"_2'ipl" | ||
| // CHECK-NEXT: %5 = fmul fast float %4, %x.0.val | ||
| // CHECK-NEXT: %6 = insertvalue [4 x float] undef, float %5, 0 | ||
| // CHECK-NEXT: %7 = fadd fast float %"_2'ipl1", %"_2'ipl1" | ||
| // CHECK-NEXT: %8 = fmul fast float %7, %x.0.val | ||
| // CHECK-NEXT: %9 = insertvalue [4 x float] %6, float %8, 1 | ||
| // CHECK-NEXT: %10 = fadd fast float %"_2'ipl2", %"_2'ipl2" | ||
| // CHECK-NEXT: %11 = fmul fast float %10, %x.0.val | ||
| // CHECK-NEXT: %12 = insertvalue [4 x float] %9, float %11, 2 | ||
| // CHECK-NEXT: %13 = fadd fast float %"_2'ipl3", %"_2'ipl3" | ||
| // CHECK-NEXT: %14 = fmul fast float %13, %x.0.val | ||
|
Comment on lines
+36
to
+46
Member
There was a problem hiding this comment. Unless ZuseZ4 prefers this sort of exact matching, this could use CHECK-DAG so we can capture the operations we're actually concerned about: four insertvalues, and an fadd and fmul apiece, in any order. |
||
| // CHECK-NEXT: %[[RETVAR:[0-9]+]] = insertvalue [4 x float] %{{[0-9]+}, float %{{[0-9]+}, 3 | ||
| // CHECK-NEXT: ret [4 x float] %[[RETVAR]] | ||
| // CHECK-NEXT: } | ||
|
|
||
| // d_square1, the extra float is the original return value (x * x) | ||
| // CHECK: define internal fastcc { float, [4 x float] } @fwddiffe4square.{{[0-9]+}}(float %x.0.val, [4 x ptr] %"x'") | ||
|
Member
There was a problem hiding this comment. same idea as my comment on R26 |
||
| // CHECK-NEXT: start: | ||
| // CHECK-NEXT: %0 = extractvalue [4 x ptr] %"x'", 0 | ||
| // CHECK-NEXT: %"_2'ipl" = load float, ptr %0, align 4 | ||
|
|
@@ -64,28 +59,23 @@ fn square(x: &f32) -> f32 { | |
| // CHECK-NEXT: %"_2'ipl2" = load float, ptr %2, align 4 | ||
| // CHECK-NEXT: %3 = extractvalue [4 x ptr] %"x'", 3 | ||
| // CHECK-NEXT: %"_2'ipl3" = load float, ptr %3, align 4 | ||
| // CHECK-NEXT: %_0 = fmul float %x.0.val, %x.0.val | ||
| // CHECK-NEXT: %4 = fadd fast float %"_2'ipl", %"_2'ipl" | ||
| // CHECK-NEXT: %5 = fmul fast float %4, %x.0.val | ||
| // CHECK-NEXT: %6 = insertvalue [4 x float] undef, float %5, 0 | ||
| // CHECK-NEXT: %7 = fadd fast float %"_2'ipl1", %"_2'ipl1" | ||
| // CHECK-NEXT: %8 = fmul fast float %7, %x.0.val | ||
| // CHECK-NEXT: %9 = insertvalue [4 x float] %6, float %8, 1 | ||
| // CHECK-NEXT: %10 = fadd fast float %"_2'ipl2", %"_2'ipl2" | ||
| // CHECK-NEXT: %11 = fmul fast float %10, %x.0.val | ||
| // CHECK-NEXT: %12 = insertvalue [4 x float] %9, float %11, 2 | ||
| // CHECK-NEXT: %13 = fadd fast float %"_2'ipl3", %"_2'ipl3" | ||
| // CHECK-NEXT: %14 = fmul fast float %13, %x.0.val | ||
| // CHECK-NEXT: %15 = insertvalue [4 x float] %12, float %14, 3 | ||
| // CHECK-NEXT: %16 = insertvalue { float, [4 x float] } undef, float %_0, 0 | ||
| // CHECK-NEXT: %17 = insertvalue { float, [4 x float] } %16, [4 x float] %15, 1 | ||
| // CHECK-NEXT: ret { float, [4 x float] } %17 | ||
| // CHECK-NEXT: } | ||
|
Comment on lines
+62
to
+78
Member
There was a problem hiding this comment. all I would say here is reiterating previous commentary |
||
|
|
||
| fn main() { | ||
| let x = std::hint::black_box(3.0); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is its return type now?