test: update llvm ir expectations for autodiff tests when dlopen #149986
+42
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
sgasho
changed the title
rustbot
added
S-waiting-on-review
Merged
Contributor
Author
|
rustbot
added
S-waiting-on-author
sgasho
force-pushed
the
test/update_autodiff_related_tests
branch
from
2cefacd to
5e6d5bb
Compare
Contributor
Author
|
I confirmed that all tests pass 
|
rustbot
added
S-waiting-on-review
Contributor
Author
|
(I don't have much time to wait CI results so I'm re-opening this PR now, during CIs are running) |
| // d_square3, the extra float is the original return value (x * x) | ||
| // CHECK: define internal { float, [4 x float] } @fwddiffe4square.1(ptr noalias noundef readonly align 4 captures(none) dereferenceable(4) %x, [4 x ptr] %"x'") | ||
| // d_square1, the extra float is the original return value (x * x) | ||
| // CHECK: define internal fastcc { float, [4 x float] } @fwddiffe4square.{{[0-9]+}}(float %x.0.val, [4 x ptr] %"x'") |
Member
There was a problem hiding this comment.
same idea as my comment on R26
Comment on lines
+36
to
+46
| // CHECK-NEXT: %4 = fadd fast float %"_2'ipl", %"_2'ipl" | ||
| // CHECK-NEXT: %5 = fmul fast float %4, %x.0.val | ||
| // CHECK-NEXT: %6 = insertvalue [4 x float] undef, float %5, 0 | ||
| // CHECK-NEXT: %7 = fadd fast float %"_2'ipl1", %"_2'ipl1" | ||
| // CHECK-NEXT: %8 = fmul fast float %7, %x.0.val | ||
| // CHECK-NEXT: %9 = insertvalue [4 x float] %6, float %8, 1 | ||
| // CHECK-NEXT: %10 = fadd fast float %"_2'ipl2", %"_2'ipl2" | ||
| // CHECK-NEXT: %11 = fmul fast float %10, %x.0.val | ||
| // CHECK-NEXT: %12 = insertvalue [4 x float] %9, float %11, 2 | ||
| // CHECK-NEXT: %13 = fadd fast float %"_2'ipl3", %"_2'ipl3" | ||
| // CHECK-NEXT: %14 = fmul fast float %13, %x.0.val |
Member
There was a problem hiding this comment.
Unless ZuseZ4 prefers this sort of exact matching, this could use CHECK-DAG so we can capture the operations we're actually concerned about: four insertvalues, and an fadd and fmul apiece, in any order.
Comment on lines
+62
to
+78
| // CHECK-NEXT: %_0 = fmul float %x.0.val, %x.0.val | ||
| // CHECK-NEXT: %4 = fadd fast float %"_2'ipl", %"_2'ipl" | ||
| // CHECK-NEXT: %5 = fmul fast float %4, %x.0.val | ||
| // CHECK-NEXT: %6 = insertvalue [4 x float] undef, float %5, 0 | ||
| // CHECK-NEXT: %7 = fadd fast float %"_2'ipl1", %"_2'ipl1" | ||
| // CHECK-NEXT: %8 = fmul fast float %7, %x.0.val | ||
| // CHECK-NEXT: %9 = insertvalue [4 x float] %6, float %8, 1 | ||
| // CHECK-NEXT: %10 = fadd fast float %"_2'ipl2", %"_2'ipl2" | ||
| // CHECK-NEXT: %11 = fmul fast float %10, %x.0.val | ||
| // CHECK-NEXT: %12 = insertvalue [4 x float] %9, float %11, 2 | ||
| // CHECK-NEXT: %13 = fadd fast float %"_2'ipl3", %"_2'ipl3" | ||
| // CHECK-NEXT: %14 = fmul fast float %13, %x.0.val | ||
| // CHECK-NEXT: %15 = insertvalue [4 x float] %12, float %14, 3 | ||
| // CHECK-NEXT: %16 = insertvalue { float, [4 x float] } undef, float %_0, 0 | ||
| // CHECK-NEXT: %17 = insertvalue { float, [4 x float] } %16, [4 x float] %15, 1 | ||
| // CHECK-NEXT: ret { float, [4 x float] } %17 | ||
| // CHECK-NEXT: } |
Member
There was a problem hiding this comment.
all I would say here is reiterating previous commentary
| // debug-NEXT: define internal { float, float } | ||
| // debug-SAME: (ptr align 4 %x, ptr align 4 %bx_0, ptr align 4 %y, ptr align 4 %by_0) | ||
| // release-NEXT: define internal fastcc { float, float } | ||
| // release-NEXT: define internal fastcc |
Member
There was a problem hiding this comment.
what is its return type now?
Comment on lines
+25
to
+27
| // CHECK: define internal{{.*}} @diffe_{{.*}}generic6square | ||
| // CHECK-SAME: double | ||
| // CHECK: f{{add|mul}} {{.*}} double |
Member
There was a problem hiding this comment.
hm. this looks very different, now?
Co-authored-by: Jubilee <[email protected]>
Co-authored-by: Jubilee <[email protected]>
Co-authored-by: Jubilee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related pr: #149271
r? @ZuseZ4