Add komet.rust-stellar derivation that provides cargo and stellar in PATH#84
Merged
automergerpr-permission-manager[bot] merged 6 commits intomasterfrom May 30, 2025
Merged
Conversation
Contributor
Author
|
This pull request also overrides |
This was referenced May 30, 2025
Merged
bbyalcinkaya
approved these changes
May 30, 2025
e78a9a8 to
ed1e423
Compare
Contributor
Author
|
@tothtamas28 Would you mind reviewing the nix changes? |
Contributor
Author
|
Force pushed a rebase with the master branch. |
tothtamas28
approved these changes
May 30, 2025
komet.rust-soroban derivation that provides cargo and soroban in PATHkomet.rust-stellar derivation that provides cargo and stellar in PATH
Contributor
Author
|
Renamed |
44a4f91
into
master
10 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nix flake provides the
kometderivation that requirescargoandstellarto be available at runtime. Therefore, a user that installskometmust also installcargowith, e.g.,rustupand installstellarwith, e.g.,cargo.Akin to
kontrol, an additional derivation can be provided in the nix flake that adds these two dependencies in the PATH of the executable to make the tools available at runtime. This has the benefit of increased reproducibility for use in, e.g., CI.This pull requests introduces this derivation in the nix flake as the attribute
komet.rust-stellar. It uses a rust distribution fromgithub:oxalica/rust-overlay. Additionally, the rust target was changed fromwasm32-unknown-unknowntowasm32v1-nonedue to respective upstream changes in stellar-cli introduced with stellar/stellar-cli#2022. Finally, thestellarexecutable that previously was provided in a nix develop shell, is instead now built from the new nix flake available in the stellar-cli repository.The
kometderivation that uses user-providedcargoandstellarcan be build withnix build .#kometand thekometderivation that purely providescargoandstellarcan be built withnix build .#komet.rust-stellar.