gh-47272: report old mailbox patches #142509
Open
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi, the PR's title will eventually became the commit message if been merged, so please clarify with what this PR changed briefly in the title. |
aisk
reviewed
Dec 10, 2025
| if len(changes) == 0: | ||
| return | ||
| for name, key_list in sequences.items(): | ||
| for key_list in sequences.values(): |
Contributor
There was a problem hiding this comment.
Although we don't use the name variable here, but I think in now days we should fix one thing in a PR, I think this line's change is to trivial to touch it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This Pull Request is an evidence of what should be changed if we wanted to report an old patch to the current codebase.
I am using this as a support of the discussion going on in the issue.