mailbox module, two small fixes

[gpolo]

BPO	3022
Nosy	@warsaw, @birkenfeld, @vstinner, @bitdancer, @akheron
Files	mailbox_fixes.diff test_get_message_with_sequences.diff mailbox.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2008-06-01.21:29:32.401>
labels = ['type-bug', 'library', 'expert-email']
title = 'mailbox module, two small fixes'
updated_at = <Date 2014-02-03.19:07:28.582>
user = 'https://bugs.python.org/gpolo'

bugs.python.org fields:

activity = <Date 2014-02-03.19:07:28.582>
actor = 'BreamoreBoy'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)', 'email']
creation = <Date 2008-06-01.21:29:32.401>
creator = 'gpolo'
dependencies = []
files = ['10497', '10498', '11918']
hgrepos = []
issue_num = 3022
keywords = ['patch']
message_count = 8.0
messages = ['67605', '67606', '67607', '75420', '83718', '88680', '110639', '111412']
nosy_count = 6.0
nosy_names = ['barry', 'georg.brandl', 'vstinner', 'gpolo', 'r.david.murray', 'petri.lehtinen']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue3022'
versions = ['Python 3.1', 'Python 2.7', 'Python 3.2']

Linked PRs

• gh-47272: report old mailbox patches #142509

[gpolo]

While fixing the tkinter demos, I found some problems when moving from
mhlib to mailbox that are corrected in the attached patch.

The first fix:

•    for name, key_list in self.get_sequences():
  

+ for name, key_list in self.get_sequences().iteritems():

I'm not sure someone else used the module before, or at least
get_sequences() since it returns a dict and it just fails in the current
code.

The second fix is about the .mh_sequences file format I found here, it
may have some lines with one space, or two, after its content which was
causing the get_sequences() to fail too.

[gpolo]

Erm.. sorry, the first correction is directly related to get_message not
get_sequences per se.

[gpolo]

Added a test case

[vstinner]

@gpolo: your patch is correct, but I prefer line.rstrip() to
line.strip(). My new patch combines your two patches + replace strip
by rstrip + use itervalues() instead of items() in MH.pack().

[vstinner]

Ping. Nobody is interested by the patch?

[bitdancer]

The iteritems problem was fixed in r71046 from bpo-2625. The tests in
mailbox.patch all pass at this point, though it doesn't look like the
line with blanks issue has been addressed in the code.

[BreamoreBoy]

Anyone interested in taking this forward?

[vstinner]

self.get_sequences() => self.get_sequences().iteritems() was fixed in trunk (r71046) and py3k (r71067).

The patch on .get_sequences() has no test: (test_get_message_with_sequences() doesn't fail without the patch.