Remove experimental feature gate on source edit

doc/ReleaseNotes.md

@@ -3,15 +3,9 @@
 * Bumped the winget version to 1.28 to match the package version.
 * Additional [options for limiting the size of log files](https://github.com/microsoft/winget-cli/blob/master/doc/Settings.md#file).
 
-# Experimental Feature: 'sourceEdit'
+# Feature: 'source edit'
 New feature that adds an 'edit' subcommand to the 'source' command. This can be used to set an explicit source to be implicit and vice-versa. For example, with this feature you can make the 'winget-font' source an implicit source instead of explicit source.
 
-To enable this feature, add the 'sourceEdit' experimental feature to your settings.
-```
-"experimentalFeatures": {
-    "sourceEdit": true
-},
-```
 To use the feature, try `winget source edit winget-font` to set the Explicit state to the default.
 
 ## Bug Fixes

doc/Settings.md

@@ -394,16 +394,6 @@ This feature enables support for fonts via `winget settings`. The `winget font l
   },
 ```
 
-### sourceEdit
-
-This feature enables support for additional source command improvements via `winget settings`. The `winget source edit` command will become available with this feature.
-
-```json
-  "experimentalFeatures": {
-        "sourceEdit": true
-  },
-```
-
 ### listDetails
 
 This feature enables support for displaying detailed output from the `list` command. Rather than a table view of the results, when the `--details` option is provided

schemas/JSON/settings/settings.schema.0.2.json

@@ -333,11 +333,6 @@
           "description": "Enable detailed output option for list command",
           "type": "boolean",
           "default": false
-        },
-        "sourceEdit": {
-          "description": "Enable source edit command",
-          "type": "boolean",
-          "default": false
         }
       }
     }

src/AppInstallerCLICore/Commands/SourceCommand.cpp

@@ -359,7 +359,6 @@ namespace AppInstaller::CLI
     void SourceEditCommand::ExecuteInternal(Context& context) const
     {
         context <<
-            Workflow::EnsureFeatureEnabled(Settings::ExperimentalFeature::Feature::SourceEdit) <<
             Workflow::EnsureRunningAsAdmin <<
             Workflow::GetSourceListWithFilter <<
             Workflow::EditSources;

src/AppInstallerCLICore/Commands/SourceCommand.h

@@ -124,7 +124,7 @@ namespace AppInstaller::CLI
 
     struct SourceEditCommand final : public Command
     {
-        SourceEditCommand(std::string_view parent) : Command("edit", { "config", "set" }, parent, Settings::ExperimentalFeature::Feature::SourceEdit) {}
+        SourceEditCommand(std::string_view parent) : Command("edit", { "config", "set" }, parent) {}
 
         std::vector<Argument> GetArguments() const override;
 

src/AppInstallerCommonCore/ExperimentalFeature.cpp

@@ -46,8 +46,6 @@ namespace AppInstaller::Settings
                 return userSettings.Get<Setting::EFFonts>();
             case ExperimentalFeature::Feature::ListDetails:
                 return userSettings.Get<Setting::EFListDetails>();
-            case ExperimentalFeature::Feature::SourceEdit:
-                return userSettings.Get<Setting::EFSourceEdit>();
             default:
                 THROW_HR(E_UNEXPECTED);
             }
@@ -83,9 +81,6 @@ namespace AppInstaller::Settings
             return ExperimentalFeature{ "Font", "fonts", "https://aka.ms/winget-settings", Feature::Font };
         case Feature::ListDetails:
             return ExperimentalFeature{ "List Details", "listDetails", "https://aka.ms/winget-settings", Feature::ListDetails };
-        case Feature::SourceEdit:
-            return ExperimentalFeature{ "Source Editing", "sourceEdit", "https://aka.ms/winget-settings", Feature::SourceEdit };
-
         default:
             THROW_HR(E_UNEXPECTED);
         }

src/AppInstallerCommonCore/Public/winget/ExperimentalFeature.h

@@ -26,7 +26,6 @@ namespace AppInstaller::Settings
             Resume = 0x2,
             Font = 0x4,
             ListDetails = 0x8,
-            SourceEdit = 0x10,
             Max, // This MUST always be after all experimental features
 
             // Features listed after Max will not be shown with the features command

src/AppInstallerCommonCore/Public/winget/UserSettings.h

@@ -77,7 +77,6 @@ namespace AppInstaller::Settings
         EFResume,
         EFFonts,
         EFListDetails,
-        EFSourceEdit,
         // Telemetry
         TelemetryDisable,
         // Install behavior
@@ -166,7 +165,6 @@ namespace AppInstaller::Settings
         SETTINGMAPPING_SPECIALIZATION(Setting::EFResume, bool, bool, false, ".experimentalFeatures.resume"sv);
         SETTINGMAPPING_SPECIALIZATION(Setting::EFFonts, bool, bool, false, ".experimentalFeatures.fonts"sv);
         SETTINGMAPPING_SPECIALIZATION(Setting::EFListDetails, bool, bool, false, ".experimentalFeatures.listDetails"sv);
-        SETTINGMAPPING_SPECIALIZATION(Setting::EFSourceEdit, bool, bool, false, ".experimentalFeatures.sourceEdit"sv);
         // Telemetry
         SETTINGMAPPING_SPECIALIZATION(Setting::TelemetryDisable, bool, bool, false, ".telemetry.disable"sv);
         // Install behavior

src/AppInstallerCommonCore/UserSettings.cpp

@@ -268,7 +268,6 @@ namespace AppInstaller::Settings
         WINGET_VALIDATE_PASS_THROUGH(EFResume)
         WINGET_VALIDATE_PASS_THROUGH(EFFonts)
         WINGET_VALIDATE_PASS_THROUGH(EFListDetails)
-        WINGET_VALIDATE_PASS_THROUGH(EFSourceEdit)
         WINGET_VALIDATE_PASS_THROUGH(AnonymizePathForDisplay)
         WINGET_VALIDATE_PASS_THROUGH(TelemetryDisable)
         WINGET_VALIDATE_PASS_THROUGH(InteractivityDisable)