Open
Conversation
db81b1d to
6b94bbf
Compare
ab427c9 to
5931bb1
Compare
61a3cba to
bf27c30
Compare
36cd149 to
bfc96b8
Compare
68c3bd2 to
9d40274
Compare
0be19eb to
9637a93
Compare
a43e58d to
2c0b58a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do you think about adding a dry run of the publisher and retag scripts to the CI? It would e.g. detect changes that require coordinated updates to the DT repo, and isn't too expensive, I think?
What I did was:
defaultLocalOptionswithdefaultRemoteOptionsifGITHUB_ACTIONSis true:DefinitelyTyped-tools/packages/publisher/src/publish-packages.ts
Line 26 in 8665394
retag.jssince f958fa4.DefinitelyTyped-tools/packages/publisher/src/lib/secrets.ts
Lines 29 to 34 in 8665394
Here's an example of it working: https://github.com/microsoft/DefinitelyTyped-tools/actions/runs/2284182030