Open
Conversation
sandersn
requested changes
Oct 23, 2020
Member
sandersn
left a comment
There was a problem hiding this comment.
Couple of requests:
- I feel like this should be a periodic cleanup task rather than something that runs every publish. So maybe this should be a standalone scripty package like retag, or even a script in DT proper.
- I'm curious about the list of affected packages and their deprecation messages. Can you dump those here? I want to know what that looks like before taking this change.
@orta can you review the graphql? I think you know it the best of any of us on the team. (It looks plausible to me though.)
6fba113 to
a14ab1a
Compare
Contributor
Author
Done ✔️
Currently the following five: Deprecating fingerprintjs2
Deprecating @types/fingerprintjs2 with message: 🤖 Merge PR #48103 feat: add fingerprintjs__fingerprintjs types by @lb… (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48103)
Deprecating openapi-v3
Deprecating @types/openapi-v3 with message: Removed OpenApi-v3 types (#46819) (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46819)
Deprecating fingerprintjs
Deprecating @types/fingerprintjs with message: 🤖 Merge PR #48103 feat: add fingerprintjs__fingerprintjs types by @lb… (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48103)
Deprecating markerclustererplus
Deprecating @types/markerclustererplus with message: Change folder name to google__markerclustererplus to match scoped pac… (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/42121)
Deprecating storybook__polymer
Deprecating @types/storybook__polymer with message: [storybook__polymer] Remove types (#48796) (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48796) |
Member
|
@sandersn, would you mind updating your review? I’m fine with this, but the package.json needs |
sandersn
previously approved these changes
Mar 31, 2021
raghavthind2005
approved these changes
Apr 19, 2022
andrewbranch
requested changes
Apr 19, 2022
266c409 to
cacb5ca
Compare
76e48bb to
a2d71d4
Compare
020fdef to
44c24a2
Compare
8b8d9cb to
c87e95b
Compare
1377299 to
e88c032
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loop over the
@typesnpm packages and mark any that no longer exist in HEAD (either in thetypesdirectory or innotNeededPackages.json) as deprecated.