Skip to content

Comments

revert: exclude metadata when refetching feed after new message received#857

Merged
mattmikolay merged 1 commit intomainfrom
mattmik-kno-11660-sdks-revert-exclusion-of-metadata-when-refetching-feed-after
Feb 12, 2026
Merged

revert: exclude metadata when refetching feed after new message received#857
mattmikolay merged 1 commit intomainfrom
mattmik-kno-11660-sdks-revert-exclusion-of-metadata-when-refetching-feed-after

Conversation

@mattmikolay
Copy link
Contributor

This reverts PR #853 (commit 1e75952). We decided against releasing this change; see this Slack thread for context.

Checklist

  • Tests have been added for new features or major refactors to existing features.

@linear
Copy link

linear bot commented Feb 12, 2026

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2026

⚠️ No Changeset found

Latest commit: fc9f195

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Feb 12, 2026 9:21pm
javascript-nextjs-example Ready Ready Preview, Comment Feb 12, 2026 9:21pm
javascript-slack-connect-example Ready Ready Preview, Comment Feb 12, 2026 9:21pm
javascript-slack-kit-example Ready Ready Preview, Comment Feb 12, 2026 9:21pm

Request Review

@mattmikolay mattmikolay marked this pull request as ready for review February 12, 2026 21:24
Comment on lines -86 to -89
"inserted_at.gte"?: string;
"inserted_at.lte"?: string;
"inserted_at.gt"?: string;
"inserted_at.lt"?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thomas asked the same question here. I added these in #853 because they were missing from the FetchFeedOptionsForRequest type. I can add them back in a separate PR, though I don’t think it’s much of an issue, since the FetchFeedOptionsForRequest type is only meant for internal use by the client SDK.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@mattmikolay mattmikolay merged commit 49b0615 into main Feb 12, 2026
12 checks passed
@mattmikolay mattmikolay deleted the mattmik-kno-11660-sdks-revert-exclusion-of-metadata-when-refetching-feed-after branch February 12, 2026 21:34
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.45%. Comparing base (1e75952) to head (fc9f195).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
+ Coverage   68.35%   68.45%   +0.09%     
==========================================
  Files         193      193              
  Lines        8122     8062      -60     
  Branches     1076     1065      -11     
==========================================
- Hits         5552     5519      -33     
+ Misses       2550     2518      -32     
- Partials       20       25       +5     
Files with missing lines Coverage Δ
packages/client/src/clients/feed/feed.ts 81.81% <100.00%> (-0.66%) ⬇️
packages/client/src/clients/feed/store.ts 100.00% <100.00%> (ø)
packages/client/src/clients/feed/utils.ts 100.00% <ø> (ø)

... and 11 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants