chore(KNO-11661): improve FetchFeedOptionsForRequest type#858
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 4b53803 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #858 +/- ##
=======================================
Coverage 67.34% 67.34%
=======================================
Files 203 203
Lines 8461 8461
Branches 1101 1101
=======================================
Hits 5698 5698
Misses 2738 2738
Partials 25 25
|
Description
This PR updates the
FetchFeedOptionsForRequesttype to improve some comments and add the following missing fields:inserted_at.gteinserted_at.gtinserted_at.lteinserted_at.ltFetchFeedOptionsForRequestis meant to represent the params included in the API request. Notice that themergeDateRangeParamsfunction transforms theinserted_at_date_rangeoption onFeedClientOptionsinto the appropriate date params, e.g.inserted_at.gte,inserted_at.lte, etc.javascript/packages/client/src/clients/feed/utils.ts
Lines 25 to 50 in 9313398
I made a similar change as part of #853, but it was reverted by #857.
Checklist