Skip to content

Conversation

@ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Jan 27, 2026

No description provided.

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jan 27, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ohmayr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the project's Python code quality tooling by migrating from a combination of black and isort to the single, high-performance ruff tool. This change simplifies the development workflow by consolidating formatting and import sorting into one command, aiming to improve efficiency and maintain consistent code style.

Highlights

  • Tool Replacement: Replaced black and isort with ruff for Python code formatting and import sorting across the project's noxfile.py configurations.
  • Nox Session Updates: Modified the lint and format nox sessions to utilize ruff's capabilities for checking imports, formatting, and applying fixes.
  • Deprecation of blacken session: The blacken nox session has been deprecated and now internally calls ruff format, with a warning message guiding users to the format session.
  • Exclusion Logic: Updated the exclusion logic for linting paths to align with ruff's glob-based exclusion patterns, replacing black's regex-based exclusions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively replaces isort and black with ruff for code formatting and import sorting across various noxfile.py configurations. The changes are logical, and I appreciate the effort to maintain backward compatibility by deprecating the blacken session with a clear warning. My review focuses on improving maintainability by ensuring the newly introduced RUFF_VERSION constant is used consistently across all session.install calls.

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 27, 2026
@ohmayr ohmayr force-pushed the update-nox-format-session-to-use-ruff branch from b0f881d to 2959030 Compare January 27, 2026 23:30
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Jan 27, 2026
@ohmayr ohmayr force-pushed the update-nox-format-session-to-use-ruff branch from 4bb97c2 to 4e9959f Compare January 28, 2026 00:16
@ohmayr ohmayr marked this pull request as ready for review January 28, 2026 00:32
@ohmayr ohmayr requested a review from a team as a code owner January 28, 2026 00:32
]
update_service_yaml = _add_python_settings(tmp_dir, python_settings)
session.run("python", "-c" f"{update_service_yaml}")
session.run("python", f"-c{update_service_yaml}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this right? It seems like there's no space between the -c and the update_service_yaml

@ohmayr ohmayr force-pushed the update-nox-format-session-to-use-ruff branch from 4e9959f to eec3a67 Compare January 28, 2026 01:13
@ohmayr ohmayr force-pushed the update-nox-format-session-to-use-ruff branch from 679c9d7 to 4e80067 Compare January 28, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants