-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
theme: remove chonk feature flags #104828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+0
−103
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5dddcd5
theme: remove chonk feature flags
JonasBa 39b6a6d
theme: remove prefers_chonk_ui
JonasBa 6ad1d5d
theme: remove lingering chonk usage
JonasBa bfb9857
theme: remove lingering chonk usage
JonasBa ef8b3ea
Merge branch 'master' into jb/chonk/flags
JonasBa 94911aa
Merge branch 'master' into jb/chonk/flags
JonasBa 45b2da1
user: remove chonk from user details
JonasBa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,7 +49,6 @@ def test_lookup_self(self) -> None: | |
| assert resp.data["options"]["stacktraceOrder"] == int(StacktraceOrder.DEFAULT) | ||
| assert not resp.data["options"]["clock24Hours"] | ||
| assert not resp.data["options"]["prefersIssueDetailsStreamlinedUI"] | ||
| assert not resp.data["options"]["prefersChonkUI"] | ||
|
|
||
| def test_superuser_simple(self) -> None: | ||
| self.login_as(user=self.superuser, superuser=True) | ||
|
|
@@ -120,7 +119,6 @@ def test_simple(self) -> None: | |
| "clock24Hours": True, | ||
| "extra": True, | ||
| "prefersIssueDetailsStreamlinedUI": True, | ||
| "prefersChonkUI": True, | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the only frontend change which will be removed once the dependent PR is merged |
||
| }, | ||
| ) | ||
|
|
||
|
|
@@ -143,7 +141,6 @@ def test_simple(self) -> None: | |
| assert UserOption.objects.get_value( | ||
| user=self.user, key="prefers_issue_details_streamlined_ui" | ||
| ) | ||
| assert UserOption.objects.get_value(user=self.user, key="prefers_chonk_ui") | ||
|
|
||
| assert not UserOption.objects.get_value(user=self.user, key="extra") | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -452,60 +452,3 @@ def test_preconnect(self) -> None: | |
| '<link rel="preconnect" href="https://s1.sentry-cdn.com"' | ||
| in response_body.decode("utf-8") | ||
| ) | ||
|
|
||
| def test_prefers_chonk_ui_enforced(self) -> None: | ||
| user = self.create_user("[email protected]") | ||
| org = self.create_organization(owner=user) | ||
| self.login_as(user) | ||
|
|
||
| with self.feature( | ||
| { | ||
| "organizations:chonk-ui": [org.slug], | ||
| "organizations:chonk-ui-enforce": [org.slug], | ||
| } | ||
| ): | ||
| response = self.client.get("/issues/", HTTP_HOST=f"{org.slug}.testserver") | ||
| assert response.status_code == 200 | ||
| assert response.context["prefers_chonk_ui"] is True | ||
|
|
||
| def test_prefers_chonk_ui_user_preference(self) -> None: | ||
| from sentry.users.models.user_option import UserOption | ||
|
|
||
| user = self.create_user("[email protected]") | ||
| org = self.create_organization(owner=user) | ||
| self.login_as(user) | ||
|
|
||
| UserOption.objects.set_value(user=user, key="prefers_chonk_ui", value=True) | ||
|
|
||
| with self.feature({"organizations:chonk-ui": [org.slug]}): | ||
| response = self.client.get("/issues/", HTTP_HOST=f"{org.slug}.testserver") | ||
| assert response.status_code == 200 | ||
| assert response.context["prefers_chonk_ui"] is True | ||
|
|
||
| def test_prefers_chonk_ui_disabled(self) -> None: | ||
| user = self.create_user("[email protected]") | ||
| org = self.create_organization(owner=user) | ||
| self.login_as(user) | ||
|
|
||
| response = self.client.get("/issues/", HTTP_HOST=f"{org.slug}.testserver") | ||
| assert response.status_code == 200 | ||
| assert response.context["prefers_chonk_ui"] is False | ||
|
|
||
| def test_prefers_chonk_ui_enforce_overrides_user_preference(self) -> None: | ||
| from sentry.users.models.user_option import UserOption | ||
|
|
||
| user = self.create_user("[email protected]") | ||
| org = self.create_organization(owner=user) | ||
| self.login_as(user) | ||
|
|
||
| UserOption.objects.set_value(user=user, key="prefers_chonk_ui", value=False) | ||
|
|
||
| with self.feature( | ||
| { | ||
| "organizations:chonk-ui": [org.slug], | ||
| "organizations:chonk-ui-enforce": [org.slug], | ||
| } | ||
| ): | ||
| response = self.client.get("/issues/", HTTP_HOST=f"{org.slug}.testserver") | ||
| assert response.status_code == 200 | ||
| assert response.context["prefers_chonk_ui"] is True | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.