-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
theme: remove chonk feature flags #104828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "prefersIssueDetailsStreamlinedUI": options.get( | ||
| "prefers_issue_details_streamlined_ui" | ||
| ), | ||
| "prefersChonkUI": options.get("prefers_chonk_ui"), | ||
| } | ||
|
|
||
| d["flags"] = {"newsletter_consent_prompt": bool(obj.flags.newsletter_consent_prompt)} |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104828 +/- ##
===========================================
+ Coverage 80.45% 80.53% +0.08%
===========================================
Files 9396 9377 -19
Lines 403551 402474 -1077
Branches 25904 25694 -210
===========================================
- Hits 324668 324138 -530
+ Misses 78448 77901 -547
Partials 435 435 |
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
| "clock24Hours": True, | ||
| "extra": True, | ||
| "prefersIssueDetailsStreamlinedUI": True, | ||
| "prefersChonkUI": True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only frontend change which will be removed once the dependent PR is merged
|
Typescript checks will pass once the dependent PR lands |
UI2 has been rolled out and the feature flags are no longer necessary
ref DE-657, Fix DE-658