Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@
- Discard envelopes on `4xx` and `5xx` response ([#4950](https://github.com/getsentry/sentry-java/pull/4950))
- This aims to not overwhelm Sentry after an outage or load shedding (including HTTP 429) where too many events are sent at once

### Dependencies

- Bump Gradle from v8.14.3 to v9.2.1 ([#4913](https://github.com/getsentry/sentry-java/pull/4913))
- [changelog](https://github.com/gradle/gradle/blob/master/CHANGELOG.md#v921)
- [diff](https://github.com/gradle/gradle/compare/v8.14.3...v9.2.1)

## 8.29.0

### Fixes
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.2.1-bin.zip
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Gradle wrapper JAR not updated with version bump

The distributionUrl was updated to Gradle 9.2.1, but the gradle-wrapper.jar binary file was not updated. When the wrapper distribution URL is changed, the wrapper JAR should also be regenerated or updated to ensure compatibility. This mismatch could cause build failures or unexpected behavior when developers or CI/CD systems use the wrapper.

Fix in Cursor Fix in Web

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Custom Test tasks will fail or be skipped after the Gradle 9.2.1 upgrade because they lack the now-required explicit testClassesDirs and classpath configurations.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The upgrade to Gradle 9.2.1 introduces a breaking change from Gradle 9.0 that affects custom Test tasks. Previously, these tasks implicitly used the default test source set's classpath. Now, they require explicit configuration. The codebase contains numerous custom Test tasks, such as systemTest in over 18 sample projects, which lack the necessary testClassesDirs and classpath properties. Consequently, after this upgrade, these test tasks will fail to find any test classes, leading to either build failures or, more critically, silently skipping the entire system test suite.

💡 Suggested Fix

For each custom Test task registration, such as tasks.register<Test>("systemTest"), explicitly configure the test classes and classpath. Add the following lines inside the task's configuration block:
testClassesDirs = sourceSets["test"].output.classesDirs
classpath = sourceSets["test"].runtimeClasspath

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: gradle/wrapper/gradle-wrapper.properties#L3

Potential issue: The upgrade to Gradle 9.2.1 introduces a breaking change from Gradle
9.0 that affects custom `Test` tasks. Previously, these tasks implicitly used the
default `test` source set's classpath. Now, they require explicit configuration. The
codebase contains numerous custom `Test` tasks, such as `systemTest` in over 18 sample
projects, which lack the necessary `testClassesDirs` and `classpath` properties.
Consequently, after this upgrade, these test tasks will fail to find any test classes,
leading to either build failures or, more critically, silently skipping the entire
system test suite.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7822598

networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
Loading