-
-
Notifications
You must be signed in to change notification settings - Fork 465
chore(deps): update Gradle to v9.2.1 #4913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b1e59b5 to
bc287ba
Compare
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.2.1-bin.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Gradle wrapper JAR not updated with version bump
The distributionUrl was updated to Gradle 9.2.1, but the gradle-wrapper.jar binary file was not updated. When the wrapper distribution URL is changed, the wrapper JAR should also be regenerated or updated to ensure compatibility. This mismatch could cause build failures or unexpected behavior when developers or CI/CD systems use the wrapper.
2586221 to
b69348d
Compare
daabbfd to
e69607e
Compare
ff7ab5b to
93c2943
Compare
7456ab8 to
3fc443e
Compare
11471e2 to
bf708d3
Compare
5c1c3d6 to
bdded88
Compare
683ce56 to
e046d91
Compare
e046d91 to
f3c4d6c
Compare
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.2.1-bin.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Custom Test tasks will fail or be skipped after the Gradle 9.2.1 upgrade because they lack the now-required explicit testClassesDirs and classpath configurations.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The upgrade to Gradle 9.2.1 introduces a breaking change from Gradle 9.0 that affects custom Test tasks. Previously, these tasks implicitly used the default test source set's classpath. Now, they require explicit configuration. The codebase contains numerous custom Test tasks, such as systemTest in over 18 sample projects, which lack the necessary testClassesDirs and classpath properties. Consequently, after this upgrade, these test tasks will fail to find any test classes, leading to either build failures or, more critically, silently skipping the entire system test suite.
💡 Suggested Fix
For each custom Test task registration, such as tasks.register<Test>("systemTest"), explicitly configure the test classes and classpath. Add the following lines inside the task's configuration block:
testClassesDirs = sourceSets["test"].output.classesDirs
classpath = sourceSets["test"].runtimeClasspath
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: gradle/wrapper/gradle-wrapper.properties#L3
Potential issue: The upgrade to Gradle 9.2.1 introduces a breaking change from Gradle
9.0 that affects custom `Test` tasks. Previously, these tasks implicitly used the
default `test` source set's classpath. Now, they require explicit configuration. The
codebase contains numerous custom `Test` tasks, such as `systemTest` in over 18 sample
projects, which lack the necessary `testClassesDirs` and `classpath` properties.
Consequently, after this upgrade, these test tasks will fail to find any test classes,
leading to either build failures or, more critically, silently skipping the entire
system test suite.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7822598
Bumps scripts/update-gradle.sh from v8.14.3 to v9.2.1.
Auto-generated by a dependency updater.