Remove package:intl dependency
#682
Conversation
|
I don't quite understand the CI changes though - @gspencergoog any ideas? |
| }, | ||
| 'date-time': (value) => DateTime.tryParse(value) != null, | ||
| 'date': (value) => DateTime.tryParse(value) != null, | ||
| 'time': (value) => DateTime.tryParse('0000-01-01T$value') != null, |
There was a problem hiding this comment.
Won't this now allow a "Z" where it didn't used to?
For instance, before it would have failed to parse the time "12:34:56Z", but now it will succeed.
There was a problem hiding this comment.
The behavior before was kind of undefined and depended on the locale's interpretation of the HH:mm:ss skeleton. I think this should be more precise. https://datatracker.ietf.org/doc/html/rfc3339#section-5.6 allows for a Z after the time, if I am not mistaken.
|
The CI issues might not be a problem with this PR. It looks like someone messed with the submodule specification or CI setup. I'll investigate. |
|
The CI issue was just a temporary GitHub outage. |
|
Thanks for the LGTM! I don't have merge rights here. so feel free to merge. |
2 participants
Description
Removing
package:intlfor non-internationalized formatting and parsing.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.