Skip to content

Conversation

@mosuem
Copy link
Contributor

@mosuem mosuem commented Jan 27, 2026

Description

Follow up to #682 ...

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully removes the intl dependency from both examples/custom_backend/pubspec.yaml and packages/json_schema_builder/pubspec.yaml, aligning with the pull request's stated goal. Additionally, json_schema_builder has been correctly moved to dev_dependencies in the custom_backend example, and pubspec.lock has been updated to reflect these dependency changes and minor version bumps for testing packages.

meta: ^1.16.0

dev_dependencies:
lints: ^6.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The lints package, which provides a recommended set of linting rules, has been removed from dev_dependencies. While not directly impacting functionality, removing this without an alternative linting setup could lead to a gradual degradation of code style and quality over time. It's generally advisable to maintain consistent linting practices to ensure code maintainability.

@gspencergoog gspencergoog merged commit ae69277 into flutter:main Feb 3, 2026
37 checks passed
gspencergoog pushed a commit to gspencergoog/genui that referenced this pull request Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants