Skip to content

Conversation

@Adri1
Copy link
Contributor

@Adri1 Adri1 commented Aug 7, 2025

Some typos, update apostrophes where possible, some typos, and French corrections

@Naramsim
Copy link
Member

Naramsim commented Aug 7, 2025

Hi! Thanks for the submission! I'm not particularly keen in changing all ' into . I know it appears to be grammatically correct your change, but I'd stick to the more common ' single quote.

@Adri1
Copy link
Contributor Author

Adri1 commented Aug 7, 2025

Hi! Thanks for the submission! I'm not particularly keen in changing all ' into . I know it appears to be grammatically correct your change, but I'd stick to the more common ' single quote.

Some of these files alreay had random among ' and this is the official type of apostrophe used in all current Pokémon games

@Naramsim
Copy link
Member

Alright! It seems I'm wrong and we currently already use that type of quote!

@Naramsim Naramsim merged commit c820619 into PokeAPI:master Aug 21, 2025
8 of 9 checks passed
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants