Raise on status: Log response data #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLLiCiTiT
changed the title
iLLiCiTiT
changed the title
BigRoy
reviewed
Feb 5, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds logging of response data when HTTP requests fail, building on PR #302 which added detail messages to HTTPError responses. The goal is to provide better visibility into why requests fail by logging the complete response data.
Changes:
- Added logging and json imports to support response data logging
- Modified
RestApiResponseclass to include a logger instance - Enhanced
raise_for_statusmethod to log full response data before raising HTTPRequestError
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Log data of failed response.
Additional review information
This is follow up to prematurely merged PR #302 .
Testing notes: