Conversation
Rubocop 0.71.0 require s jaro_winkler gem which does not build with Ruby 3.4. That old version is not used anyway.
Member
OK, but that's the 0.71 version, but we use even the older 0.41 in some less used packages: $ gh search code --owner yast rubocop_yast_style.yml
yast/yast.github.io doc/rubocop.md
/usr/share/YaST2/data/devtools/data/rubocop_yast_style.yml
yast/yast-devtools ytools/y2tool/Makefile.am
dist_confdata_DATA = rubocop_yast_style.yml rubocop-0.71.0_yast_style.yml rubocop-1.24.1_yast_style.yml
yast/yast-storage-ng .codeclimate.yml
# the /usr/share/YaST2/data/devtools/data/rubocop_yast_style.yml file
yast/yast-squid .rubocop.yml
/usr/share/YaST2/data/devtools/data/rubocop_yast_style.yml
yast/yast-snapper .rubocop.yml
/usr/share/YaST2/data/devtools/data/rubocop_yast_style.yml
yast/yast-ruby-bindings .rubocop.yml
/usr/share/YaST2/data/devtools/data/rubocop_yast_style.yml
yast/yast-iscsi-lio-server .rubocop.yml
/usr/share/YaST2/data/devtools/data/rubocop_yast_style.yml
yast/yast-alternatives .rubocop.yml
/usr/share/YaST2/data/devtools/data/rubocop_yast_style.yml
yast/yast-ftp-server .rubocop.yml
/usr/share/YaST2/data/devtools/data/rubocop_yast_style.yml
yast/yast-slp-server .rubocop.yml
/usr/share/YaST2/data/devtools/data/rubocop_yast_style.yml
yast/yast-configuration-management .rubocop.yml
/usr/share/YaST2/data/devtools/data/rubocop_yast_style.yml
yast/yast-partitioner .rubocop.yml
/usr/share/YaST2/data/devtools/data/rubocop_yast_style.yml
yast/yast-migration .rubocop.yml
/usr/share/YaST2/data/devtools/data/rubocop_yast_style.yml |
mvidner
approved these changes
Jun 6, 2025
Member
mvidner
left a comment
There was a problem hiding this comment.
LGTM, if there is any fallout we will deal with it as it comes
|
✅ Autosubmission job #15491908996 successfully finished |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Testing