Fix default values for AVX and AVX512 state depending on OSXSAVE #1233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVX and AVX512 strictly require the OS to enable OXSAVE otherwise we can face "illegal instruction" depending on the context state
mhandb
changed the title
serge-sans-paille
merged commit 6e9e932
into
xtensor-stack:master
56 of 59 checks passed
Contributor
|
Thanks 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the initialization of AVX and AVX512 OS support detection in
xsimd_cpuid.hpp. The change ensures that AVX and AVX512 are only considered enabled if the OS has explicitly enabled OSXSAVE.Indeed, AVX and AVX512 strictly require the OS to enable OXSAVE otherwise we can face "illegal instruction"
https://wiki.osdev.org/SSE#AVX
For now I am using a local patch, but I would like to avoid to maintain it.
Let me know if this PR is good enough or if it needs any change.