Refactor media upload API functionality#26
Merged
santiagomed merged 1 commit intomainfrom May 8, 2025
Merged
Conversation
tapans
approved these changes
May 8, 2025
Contributor
tapans
left a comment
There was a problem hiding this comment.
thanks for teaching me GO. let's GO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog:
Extended Functionality for Traceability:
traceboolean to theMediaUploaderstruct, which allows for the inclusion of tracing information when sending requests.NewMediaUploader,NewMediaUploaderWithoutFile,ExecuteMediaUpload, andExecuteMediaStatusto maintain consistency and functionality.API Endpoint Adjustments:
/initialize), append (e.g.,/{mediaID}/append), and finalize (/{mediaID}/finalize) now have well-defined paths instead of using a query-based command approach. This follows the recent media upload changes to the X API.Refactored Data Extraction:
ExtractMediaIDandExtractSegmentIndex.ExtractCommandfunction to discern the media upload command directly from the URL path instead of relying on query parameters.Tests Adjustments:
Important Note: