Pin behat/gherkin to fix PHP 8.5 tests
#284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
force-pushed
the
fix/gherkin
branch
from
110be34 to
7524c63
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
Author
|
Obsolete now that Behat 3.27 was released with PHP 8.5 support, see https://github.com/Behat/Behat/releases/tag/v3.27.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Behat/Behat#1636 for context.
behat/gherkinhad a breaking change thatbehat/behathad to accommodate for. Since we're stuck at Behat 3.15, but were using a newer version ofbehat/gherkin, that caused an incompatibility. This showed in PHP 8.5 tests oncebehat/gherkinv4.15.0 was released which introduced 8.5 compatibility.tl;dr: this PR here will fix PHP 8.5 tests for all our commands once they update the wp-cli-tests dependency.