Conversation
Collaborator
Generated by 🚫 Danger |
2b3b6dc to
9651a5d
Compare
Contributor
Author
|
I'm not sure why the web has a different blue. I thought I used the same one in the app. It's now clear side-by-side it's not. I'll look into ways to make them more consistent. |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30680 | |
| Version | PR #25178 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | f48ea71 | |
| Installation URL | 13fq71hqqhq0o |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30680 | |
| Version | PR #25178 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | f48ea71 | |
| Installation URL | 6v1mfcfoaohbg |
bcd62b0 to
2871861
Compare
crazytonyli
reviewed
Jan 29, 2026
| // If it's a single value, return it in an array | ||
| // Remove surrounding quotes if present | ||
| let trimmed = key.trimmingCharacters(in: CharacterSet(charactersIn: "\"")) | ||
| return [trimmed] |
Contributor
There was a problem hiding this comment.
Something like this, so that we don't need to manually parse the quotes and square brackets?
let decoder = JSONDecoder()
let data = key.data(using: .utf8)
if let values = try? decoder.decode([String].self, from: data) {
return values
}
if let string = try? decoder.decode(String.self, from: data) {
return [string]
}
Contributor
Author
There was a problem hiding this comment.
It's defensive code. It does look cleaner with decoder. Updated.
crazytonyli
approved these changes
Jan 29, 2026
2871861 to
f48ea71
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Description
Closes CMM-597: Add UTM sources chart.
Similarly to #25176, it "simply" introduces one more "Top List" item type: "UTM". I used the Calypso codebase as a reference for implementing it. There is nothing out of the ordinary in this PR.
Testing instructions
I tested it end-to-end on one of the production sites. Ping me if you need more details.
Screenshots