Skip to content

TLS ECH confirmation fix and OuterExtension addition#9737

Draft
sebastian-carpenter wants to merge 4 commits intowolfSSL:masterfrom
sebastian-carpenter:tls-ech-confirmation-fix
Draft

TLS ECH confirmation fix and OuterExtension addition#9737
sebastian-carpenter wants to merge 4 commits intowolfSSL:masterfrom
sebastian-carpenter:tls-ech-confirmation-fix

Conversation

@sebastian-carpenter
Copy link

@sebastian-carpenter sebastian-carpenter commented Feb 4, 2026

Description

Original issue stems from wolfssl-examples/tls/client-ech not working. This issue was a confirmation value mismatch between Cloudflare and our ECH client implementation. The confirmation value is present in the HelloRetryRequest's encrypted_client_hello extension.

  • Confirmation mismatch was resolved by refactoring most of the transcript code for ECH.
    • Managed to remove a transcript hash that seemed unecessary. (hsHashesEchInner)
    • Merged most of the client and server calculation for ECH transcript into similar functions.
    • Random value only copied into client hello inner once now
  • Fixed segfault when server does not respond with a confirmation value
  • Added OuterExtensions extension support to the server to allow testing against openssl s_client (second confirmation that transcript hash is now correct)
    • OuterExtensions will copy extensions from the outer hello into the inner hello

Based fixes off of esni draft 25 (https://www.ietf.org/archive/id/draft-ietf-tls-esni-25.html)

Addresses github issue #6925

Testing

With ECH enabled OpenSSL:

openssl s_client -connect 127.0.0.1:11111 -servername ech-private-name.com -CAfile ../wolfssl-examples/certs/ca-cert.pem -tls1_3 -ech_config_list AEb+DQBCKwAgACARYidanwtcQUp0EfBd0qll0hpqgXpDlNj+iVAIUO5tDAAEAAEAAQATZWNoLXB1YmxpYy1uYW1lLmNvbQAA

This is run against the wolfssl-examples repo ./tls/server-ech-local example.

Also ran ./tls/client-ech-local against the example server and the updated ./tls/client-ech part of a wolfssl-example PR (wolfSSL/wolfssl-examples#556)

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@sebastian-carpenter sebastian-carpenter self-assigned this Feb 4, 2026
@sebastian-carpenter sebastian-carpenter force-pushed the tls-ech-confirmation-fix branch 2 times, most recently from f880402 to dee5c47 Compare February 4, 2026 23:52
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I'd like this PR to include testing as well. I don't see any. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants