TLS ECH confirmation fix and OuterExtension addition#9737
Draft
sebastian-carpenter wants to merge 4 commits intowolfSSL:masterfrom
Draft
TLS ECH confirmation fix and OuterExtension addition#9737sebastian-carpenter wants to merge 4 commits intowolfSSL:masterfrom
sebastian-carpenter wants to merge 4 commits intowolfSSL:masterfrom
Conversation
f880402 to
dee5c47
Compare
dee5c47 to
740c55f
Compare
dgarske
requested changes
Feb 5, 2026
Contributor
dgarske
left a comment
There was a problem hiding this comment.
Code looks good. I'd like this PR to include testing as well. I don't see any. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Original issue stems from
wolfssl-examples/tls/client-echnot working. This issue was a confirmation value mismatch between Cloudflare and our ECH client implementation. The confirmation value is present in the HelloRetryRequest's encrypted_client_hello extension.Based fixes off of esni draft 25 (https://www.ietf.org/archive/id/draft-ietf-tls-esni-25.html)
Addresses github issue #6925
Testing
With ECH enabled OpenSSL:
This is run against the wolfssl-examples repo
./tls/server-ech-localexample.Also ran
./tls/client-ech-localagainst the example server and the updated./tls/client-echpart of a wolfssl-example PR (wolfSSL/wolfssl-examples#556)Checklist