WPB-21964: Add Wire Meetings creation endpoint #4918
Conversation
zebot
added
the
ok-to-test
blackheaven
force-pushed
the
gdifolco/WPB-21964-wire-meetings-create
branch
3 times, most recently
from
b617bd6 to
82665cc
Compare
blackheaven
force-pushed
the
gdifolco/WPB-21964-wire-meetings-create
branch
from
82665cc to
f78d8e3
Compare
akshaymankar
left a comment
akshaymankar
left a comment
There was a problem hiding this comment.
I haven't reviewed everything yet, I'll continue later. But already have some feedback.
libs/wire-subsystems/postgres-migrations/20251213223355-create-meetings-table.sql
Outdated
Show resolved
Hide resolved
libs/wire-subsystems/postgres-migrations/20251213223355-create-meetings-table.sql
Outdated
Show resolved
Hide resolved
libs/wire-subsystems/postgres-migrations/20251213223355-create-meetings-table.sql
Outdated
Show resolved
Hide resolved
| CreateMeeting :: | ||
| Local UserId -> | ||
| NewMeeting -> | ||
| -- | premium: True if this is a premium meeting |
There was a problem hiding this comment.
Why is this decision made outside the subsystem?
There was a problem hiding this comment.
It'll force to move feature flags from galley to wire-subsystem, which is heavy, as it rely a lot on galley mechanisms, and couple wire-subsystem to galley.
| } | ||
|
|
||
| -- Store the conversation | ||
| storedConv <- ConvStore.upsertConversation lConvId newConv |
There was a problem hiding this comment.
We're bypassing the ConversationSubsystem business logic (I know the subsystem doesn't exist yet) here. This is dangerous. For instance, I can already tell that this would break if MLS is disabled.
There was a problem hiding this comment.
Should I wait for the PR introducing it, or could we assume it is safe as long as the conversation params do not change?
libs/wire-subsystems/postgres-migrations/20251213223355-create-meetings-table.sql
Show resolved
Hide resolved
blackheaven
force-pushed
the
gdifolco/WPB-21964-wire-meetings-create
branch
from
f78d8e3 to
7bd22a0
Compare
https://wearezeta.atlassian.net/browse/WPB-21964
Checklist
changelog.d