Mark several privacy sandbox features as discouraged #3526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
ddbeck
force-pushed
the
deprecate-privacy-sandbox
branch
2 times, most recently
from
7957bb3 to
e5ff69e
Compare
ddbeck
force-pushed
the
deprecate-privacy-sandbox
branch
from
e5ff69e to
3276862
Compare
ddbeck
changed the title
ddbeck
commented
Dec 11, 2025
ddbeck
commented
Dec 12, 2025
Comment on lines
-8
to
13
| export function convertMarkdown(markdown: string) { | ||
| export function convertMarkdown(markdown: unknown) { | ||
| if (typeof markdown !== "string") { | ||
| throw new Error(`${markdown} is not a string!`); | ||
| } | ||
|
|
||
| const mdTree = unified().use(remarkParse).parse(markdown); |
Collaborator
Author
There was a problem hiding this comment.
Remark stringifies anything, apparently, converting undefined to the string "undefined". This throw ought to stop us from "successfully" converting missing fields to strings.
Collaborator
Author
|
This is becoming more urgent as BCD has started marking the keys as deprecated: |
github-actions
bot
added
the
tools and infrastructure
ddbeck
force-pushed
the
deprecate-privacy-sandbox
branch
from
3426b70 to
c7e9327
Compare
captainbrosset
requested changes
Dec 15, 2025
Contributor
captainbrosset
left a comment
captainbrosset
left a comment
There was a problem hiding this comment.
@foolip could someone from Google please review this PR?
Contributor
|
For info, the Privacy Sandbox status page proved a useful resource to find up to date information on this: https://privacysandbox.google.com/overview/status |
samdutton
reviewed
Dec 17, 2025
samdutton
reviewed
Dec 17, 2025
samdutton
reviewed
Dec 17, 2025
samdutton
reviewed
Dec 17, 2025
samdutton
reviewed
Dec 17, 2025
samdutton
reviewed
Dec 17, 2025
samdutton
reviewed
Dec 17, 2025
samdutton
reviewed
Dec 17, 2025
samdutton
reviewed
Dec 17, 2025
samdutton
reviewed
Dec 17, 2025
captainbrosset
requested changes
Dec 18, 2025
Contributor
captainbrosset
left a comment
captainbrosset
left a comment
There was a problem hiding this comment.
Making some suggestions as per Sam's review.
captainbrosset
requested changes
Dec 18, 2025
Contributor
captainbrosset
left a comment
captainbrosset
left a comment
There was a problem hiding this comment.
More suggestions (this PR is from Daniel's fork, so I can't contribute to it directly).
captainbrosset
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google is deprecating a number of privacy sandbox features I think all of them are single implementer, so they'll qualify for deprecation in BCD and end up here too. No reason not to get ahead a little. Features affected:
attribution-reportingprotected-audience(see Addprotected-audiencefeature #2635)storage-access(break outrequestStorageAccessFor())shared-storagetopicsThere are questions about Edge on some of these, so there's some more research to be done on this.
via mdn/browser-compat-data#28417, where there's a nice list of links to intent-to-deprecate messages.