Skip to content

Remove FilesPage preview special-casing and restore default command flow#2960

Draft
Copilot wants to merge 7 commits intomainfrom
copilot/add-onboarding-preview-page
Draft

Remove FilesPage preview special-casing and restore default command flow#2960
Copilot wants to merge 7 commits intomainfrom
copilot/add-onboarding-preview-page

Conversation

Copy link
Contributor

Copilot AI commented Feb 27, 2026

FilesPage was previously previewed through a special path because EditBashrcCommand (Monaco via CodeEditor) threw in preview mode. With preview/global handling now fixed, preview can run the real Files onboarding flow end-to-end without command overrides.

  • Files preview now uses the real FilesPage path

    • OnboardingPreview renders FilesPage directly.
    • Removed preview-only command injection/override behavior for Files onboarding.
  • Reverted FilesPage customization

    • Dropped optional command renderer plumbing added for preview.
    • Restored FilesPage to its original internal command rotation:
      EditBashrcCommand -> ViewShortcutsCommand -> ViewLogoCommand.
  • Result

    • No Files-specific preview fork remains.
    • Preview and production use the same FilesPage command lifecycle.
const commands = [
    (onComplete: () => void) => <EditBashrcCommand onComplete={onComplete} />,
    (onComplete: () => void) => <ViewShortcutsCommand isMac={isMac} onComplete={onComplete} />,
    (onComplete: () => void) => <ViewLogoCommand onComplete={onComplete} />,
];

Onboarding FilesPage preview using default commands


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 28, 2026

Deploying waveterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 28491c4
Status: ✅  Deploy successful!
Preview URL: https://c24b1a4c.waveterm.pages.dev
Branch Preview URL: https://copilot-add-onboarding-previ.waveterm.pages.dev

View logs

Copilot AI changed the title [WIP] Add onboarding preview page for multiple screens Add unified onboarding preview page with in-file preview-safe variants Feb 28, 2026
Copilot AI changed the title Add unified onboarding preview page with in-file preview-safe variants Consolidate onboarding previews and make preview host scrollable Feb 28, 2026
Copilot AI changed the title Consolidate onboarding previews and make preview host scrollable Make onboarding preview scrollable and move preview-only wrappers out of app code Feb 28, 2026
Copilot AI changed the title Make onboarding preview scrollable and move preview-only wrappers out of app code Align onboarding preview with real flow components and remove FilesPage special-casing Feb 28, 2026
Copilot AI changed the title Align onboarding preview with real flow components and remove FilesPage special-casing Remove FilesPage preview special-casing and restore default command flow Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants