-
-
Notifications
You must be signed in to change notification settings - Fork 45
Update PR template to target staging branch #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @JonDevOps, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's pull request template to align with a revised branching strategy. The primary change directs contributors to submit their work against the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the PR template to change the target branch from production to staging. The change is simple and effective. I've added one minor suggestion to improve the clarity of the template for future contributors. As a side note, please remember to fully edit the PR description in the future, removing placeholders like 'edit this' and filling in the issue number.
| - [ ] I have read [w3Develops contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md). | ||
| - [ ] My pull request has a descriptive title (not a vague title like `Update index.md`) | ||
| - [ ] My pull request targets the `production` branch of production. | ||
| - [ ] My pull request targets the `staging` branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better clarity, especially for new contributors, consider explicitly mentioning that the branch is in the main repository. The previous text (... of production) was likely trying to achieve this, and adding of this repository would make the instruction clearer.
| - [ ] My pull request targets the `staging` branch. | |
| - [ ] My pull request targets the `staging` branch of this repository. |
RA9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are necessary changes. It would be nice if we can update the rules to not be the exact replica of freeCodeCamp
edit this
Update index.md)productionbranch of production.Closes #XXXXX