-
-
Notifications
You must be signed in to change notification settings - Fork 45
Remove MIT License text from LICENSE file #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @JonDevOps, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to streamline the project's licensing information by removing the explicit text of the MIT License from the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the MIT license text from the main LICENSE file. While the intention to clarify the project's primary BSD-3-Clause license is understandable, this change raises a critical concern regarding license compliance. The removed MIT license is associated with 'Blackrock Digital LLC', and the README.md suggests this project is based on their startbootstrap-agency project. Removing the license notice without confirming that all code from that project has been removed could violate the terms of the MIT license. I have left a specific comment detailing this critical issue.
I am having trouble creating individual review comments. Click here to see my feedback.
LICENSE (31-51)
Removing the MIT license notice for 'Blackrock Digital LLC' could lead to a license violation. The MIT license requires that the copyright notice and permission notice be included in all copies or substantial portions of the software. Given that this project appears to be derived from startbootstrap-agency (which is MIT licensed), it's crucial to ensure compliance. Before removing this, please verify that no code from the original project remains. If code is still being used, this license information must be retained. A common practice is to keep it in the main LICENSE file or move it to a separate file like NOTICE.md or LICENSES-THIRD-PARTY.md to clearly distinguish it from the project's primary BSD-3 license.
|
Closed because of conflicts |
edit this
Update index.md)productionbranch of production.Closes #XXXXX