-
Notifications
You must be signed in to change notification settings - Fork 11
feat: on_spot_discontinue on os_volume and delete_permanently on instance action #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for managing volume lifecycle when working with spot instances and provides a way to permanently delete volumes when deleting instances.
Changes:
- Added
OSVolumedataclass withon_spot_discontinueparameter to control volume behavior when spot instances are discontinued - Added
delete_permanentlyparameter to theaction()method to allow permanent deletion of volumes in a single operation - Updated integration tests to demonstrate the new features
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| verda/instances/_instances.py | Introduced OSVolume dataclass with on_spot_discontinue field and added delete_permanently parameter to action() method |
| verda/instances/init.py | Exported new OSVolume and OnSpotDiscontinue types |
| tests/unit_tests/instances/test_instances.py | Added unit tests for creating spot instances with OSVolume and for action() with delete_permanently |
| tests/integration_tests/test_spot_instances.py | Added integration test demonstrating spot instance creation with on_spot_discontinue set to delete_permanently |
| tests/integration_tests/test_instances.py | Updated integration test to use new delete_permanently parameter when deleting instances |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Will call API with:
Will call API: