Skip to content

Add list numbering types to ASAtom#692

Merged
MaximPlusov merged 1 commit intointegrationfrom
list-numbering-attrs
Feb 12, 2026
Merged

Add list numbering types to ASAtom#692
MaximPlusov merged 1 commit intointegrationfrom
list-numbering-attrs

Conversation

@LonelyMidoriya
Copy link
Contributor

@LonelyMidoriya LonelyMidoriya commented Feb 12, 2026

Summary by CodeRabbit

  • New Features
    • Added support for additional list formatting options including decimal numbering, alphabetic styles (uppercase and lowercase), roman numerals, and ordered/unordered list designations.

@coderabbitai
Copy link

coderabbitai bot commented Feb 12, 2026

📝 Walkthrough

Walkthrough

Seven new predefined ASAtom constants have been added to the ASAtom class: DECIMAL, LOWER_ALPHA, LOWER_ROMAN, ORDERED, UNORDERED, UPPER_ALPHA, and UPPER_ROMAN. These constants represent list formatting styles and follow alphabetically-organized naming conventions within the class.

Changes

Cohort / File(s) Summary
New ASAtom Constants
src/main/java/org/verapdf/as/ASAtom.java
Added 7 new public static final ASAtom constants for list formatting styles: DECIMAL, LOWER_ALPHA, LOWER_ROMAN, ORDERED, UNORDERED, UPPER_ALPHA, and UPPER_ROMAN.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Seven atoms now join the fold,
List styles in letters we can hold,
Ordered, unordered, roman and more,
Constants declared from shore to shore! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately reflects the primary change: adding seven new ASAtom constants for list numbering types (DECIMAL, LOWER_ALPHA, LOWER_ROMAN, ORDERED, UNORDERED, UPPER_ALPHA, UPPER_ROMAN).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch list-numbering-attrs

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MaximPlusov MaximPlusov merged commit 91a0913 into integration Feb 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments