fix: Ported master’s route injection behavior to 0.33.x

[HarshMN2345]

… route resource after wildcard resolution

Summary by CodeRabbit

• Refactor

  • Improved routing engine with better handling of fallback scenarios and optimized route resolution for more efficient request processing.

• Tests

  • Added four new tests to verify route information is properly accessible and available throughout the application's execution lifecycle, including during initialization, shutdown, error handling, and special HTTP method processing.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-SER-1093-port-route-injection-to-0.33.x

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/Http.php (1)

907-936: ⚠️ Potential issue | 🟠 Major

Dead code: This elseif branch for OPTIONS handling is unreachable.

The OPTIONS handling at lines 868-903 already returns at line 902 when $method == OPTIONS. This means the elseif (self::REQUEST_METHOD_OPTIONS == $method) branch at line 907 can never execute.

This appears to be duplicate code that should be removed.

🔧 Proposed fix: Remove dead code

         if (null !== $route) {
             return $this->execute($route, $request, $response);
-        } elseif (self::REQUEST_METHOD_OPTIONS == $method) {
-            try {
-                foreach ($groups as $group) {
-                    foreach (self::$options as $option) { // Group options hooks
-                        if (in_array($group, $option->getGroups())) {
-                            \call_user_func_array($option->getAction(), $this->getArguments($option, [], $request->getParams()));
-                        }
-                    }
-                }
-
-                foreach (self::$options as $option) { // Global options hooks
-                    if (in_array('*', $option->getGroups())) {
-                        \call_user_func_array($option->getAction(), $this->getArguments($option, [], $request->getParams()));
-                    }
-                }
-            } catch (\Throwable $e) {
-                foreach (self::$errors as $error) { // Global error hooks
-                    if (in_array('*', $error->getGroups())) {
-                        self::setResource('error', function () use ($e) {
-                            return $e;
-                        });
-                        try {
-                            $arguments = $this->getArguments($error, [], $request->getParams());
-                            \call_user_func_array($error->getAction(), $arguments);
-                        } catch (\Throwable $e) {
-                            throw new Exception('Error handler had an error: ' . $e->getMessage() . "\nStack trace: " . $e->getTraceAsString(), 500, $e);
-                        }
-                    }
-                }
-            }
         } else {
             foreach (self::$errors as $error) { // Global error hooks

🧹 Nitpick comments (1)

src/Http.php (1)

859-861: Minor: Consider using parsed path instead of raw URI for fallback route.

When no route matches and no wildcard exists, the fallback creates a Route using $request->getURI(), which may include query strings (e.g., /path?query=1). For consistency with how the wildcard route handling works (line 855 uses parse_url), consider using the parsed path.

💡 Suggested improvement

         self::setResource('route', function () use ($route, $request) {
-            return $route ?? new Route($request->getMethod(), $request->getURI());
+            $path = \parse_url($request->getURI(), PHP_URL_PATH) ?? '/';
+            return $route ?? new Route($request->getMethod(), $path);
         });

[Meldiron]

Lets use response

[Meldiron]

Have separate test function for init

[loks0n]

This seems like a hacky pattern? Can't we do the same as other tests and build a reeal request?