implement volunteer scoped availability settings content#187
Open
implement volunteer scoped availability settings content#187
Conversation
Greptile SummaryImplements volunteer-scoped availability settings with a well-structured form approach. The PR reorganizes the availability feature into dedicated components, adds a new preferred time commitment field, and extends the availability grid to show all 24 hours instead of just 9-18. Key Changes:
Minor Issue:
Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| src/components/profile/availability-input.tsx | Extended time range to 24 hours, added unsaved changes badge, renamed Save to Done button; minor syntax issue with equality operator |
| src/components/settings/pages/availability/availability-section.tsx | New component integrating availability input with form and time commitment field |
| src/components/settings/pages/availability/availability-settings-content.tsx | New main content component orchestrating data fetching, form state, and submission logic |
| src/models/api/volunteer.ts | Moved preferredTimeCommitmentHours field from profile to availability update schema |
| src/server/services/entity/volunteerService.ts | Refactored to accept full input object and properly destructure for database update |
Last reviewed commit: 83e74be
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…m/ubclaunchpad/neuron into 159-availability-settings-content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented as per #159.
One note - I added an "unsaved" badge to the availability input so users know that only the "save changes" button saves their availability and not the "done" button when editing the time slots. Another option is to have it so that "done" also saves the availability, and then I can get rid of the badge. Or something else. Lmk what u think