Trixie Tomcat updates - add config for Tomcat 11 #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnGle
approved these changes
Jan 27, 2026
Member
OnGle
left a comment
OnGle
left a comment
There was a problem hiding this comment.
Seems a bit odd to me to keep the old tomcat config but not have a method to swap back. But if it doesn't cause any issues then I don't see any actual issues with it. lgtm!
Member
Author
In essence I agree, but I figure it gives us some future flexibility - i.e. things like building both version variants as separate appliances, provide a "downgrade tomat" script or even if we have a tomcat appliance that requires a different tomcat version we have reference conf built-in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trixie has both Tomcat 10 & 11 - this is new config for 11, leaving the existing 10 conf in place. Please note that it has not been significantly tested.
TBH I wasn't sure whether we should make v10 & v11 separate, but I think that it's probably best to just bundle them together for now and just release tomcat11. If there is demand, perhaps we could build in support for changing to the other (i.e. 11 -> 10)?
Open to further thoughts..