add file watching capability to runtime execution#188
Open
whyang9701 wants to merge 3 commits intotryandromeda:mainfrom
Open
add file watching capability to runtime execution#188whyang9701 wants to merge 3 commits intotryandromeda:mainfrom
whyang9701 wants to merge 3 commits intotryandromeda:mainfrom
Conversation
Performance Comparison
|
load1n9
requested changes
Nov 11, 2025
Member
load1n9
left a comment
load1n9
left a comment
There was a problem hiding this comment.
LGTM! Can fix those CI issues before merging though
load1n9
requested changes
Nov 24, 2025
Member
load1n9
left a comment
load1n9
left a comment
There was a problem hiding this comment.
before merging can you fix these 2 lint issues real quick
error: the Err-variant returned from this function is very large
--> cli/src/run.rs:42:6
|
42 | ) -> Result<()> {
| ^^^^^^^^^^
|
::: cli/src/error.rs:45:5
|
45 | / ParseError {
46 | | diagnostics: Vec,
47 | | file_path: String,
48 | | #[source_code]
49 | | source_code: NamedSource,
50 | | error_spans: Vecmiette::SourceSpan,
51 | | },
| |- the variant ParseError contains at least 144 bytes
...
59 | / RuntimeError {
60 | | message: String,
61 | | file_path: Option,
62 | | line: Option,
... |
67 | | error_span: Option,
68 | | },
| |- the largest variant contains at least 160 bytes
|
= help: try reducing the size of error::AndromedaError, for example by boxing large elements or replacing it with Box<error::AndromedaError>
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
= note: -D clippy::result-large-err implied by -D warnings
= help: to override -D warnings add #[allow(clippy::result_large_err)]
error: this loop could be written as a while let loop
--> cli/src/run.rs:55:5
|
55 | / loop {
56 | | // Wait for the first event (blocking)
57 | | match rx.recv() {
58 | | Ok(_event) => {
... |
70 | | }
| |_____^ help: try: while let Ok(_event) = rx.recv() { .. }
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
= note: -D clippy::while-let-loop implied by -D warnings
= help: to override -D warnings add #[allow(clippy::while_let_loop)]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #181