Use an if for the compile time flag instead of removing all items#18
Open
sosthene-nitrokey wants to merge 1 commit intotrussed-dev:mainfrom
Open
Use an if for the compile time flag instead of removing all items#18sosthene-nitrokey wants to merge 1 commit intotrussed-dev:mainfrom
if for the compile time flag instead of removing all items#18sosthene-nitrokey wants to merge 1 commit intotrussed-dev:mainfrom
Conversation
sosthene-nitrokey
force-pushed
the
unused
branch
from
5013d79 to
41901aa
Compare
Member
|
Currently, the crate docs claim:
This should be updated if this change is merged. As this is a fundamental change, I’m leaving this review to @nickray. |
Contributor
Author
|
We could check in the final binary but I'd be very surprised that the compiler fails to optimize this change away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14 and #15