Upgrade node from v18 to v24 #1106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Plz update the lint_driver and trunk.yaml node versions as well, i.e. https://github.com/search?q=repo%3Atrunk-io%2Fplugins%20node%40&type=code |
|
|
|
|
|
|
|
|
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| encoding: "utf8" as const, | ||
| windowsHide: options.windowsHide, | ||
| }; | ||
| const printConfig = execSync([executable, ...args].join(" "), execOptions); |
Check warning
Code scanning / CodeQL
Shell command built from environment values Medium test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 20 hours ago
In general, to fix this class of issue you should avoid constructing a single shell command string that mixes executable paths and arguments; instead, pass the executable and arguments as separate parameters to execFileSync/execFile (or the platform equivalent). This prevents environment-controlled values (paths, args) from being interpreted by the shell.
For this concrete code, the best fix is to change getFullTrunkConfig so it no longer calls execSync with [executable, ...args].join(" "). We already have buildExecArgs returning the executable, arguments array, and options suitable for execFileSync. So in getFullTrunkConfig we can:
- Keep using
buildExecArgs(["config", "print"])to get[executable, args, options]. - Replace the
execSynccall withexecFileSync(executable, args, execOptions), whereexecOptionsis built as it is now (without specifyingshell: true). - This removes the need to join into a single string, so no shell interpretation occurs, and any spaces or special characters in
ARGS.cliPathor args are handled safely.
The only file needing modification is tests/driver/driver.ts, within the getFullTrunkConfig method. No new imports or helpers are required because execFileSync is already imported at the top of the file.
Suggested changeset
1
tests/driver/driver.ts
| @@ -310,7 +310,7 @@ | ||
| encoding: "utf8" as const, | ||
| windowsHide: options.windowsHide, | ||
| }; | ||
| const printConfig = execSync([executable, ...args].join(" "), execOptions); | ||
| const printConfig = execFileSync(executable, args, execOptions); | ||
| return YAML.parse(printConfig.replaceAll("\r\n", "\n")); | ||
| }; | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.