[INS-170] Unify JDBC URL parsing across detectors and analyzers #4574
+130
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanfcp
approved these changes
Dec 10, 2025
Contributor
amanfcp
left a comment
amanfcp
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks @mustansir14
Left a few suggestions
Comment on lines
+86
to
+90
| postgresJDBC := &PostgresJDBC{ | ||
| Host: u.Host, | ||
| Database: dbName, | ||
| Params: params, | ||
| } |
Contributor
There was a problem hiding this comment.
We can use a single ConnectionInfo struct across all handlers, and later clean it up from jdbc analyzer models.go.
Comment on lines
+137
to
140
| if h, p, found := strings.Cut(host, ":"); found { | ||
| data["host"] = h | ||
| data["port"] = p | ||
| } |
Contributor
There was a problem hiding this comment.
As per the coding guidelines
Suggested change
| if h, p, found := strings.Cut(host, ":"); found { | |
| data["host"] = h | |
| data["port"] = p | |
| } | |
| if h, p, ok := strings.Cut(host, ":"); ok { | |
| data["host"] = h | |
| data["port"] = p | |
| } |
martinlocklear
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We need to unify JDBC URL parsing across the detector and analyzer. This PR supports that by publicizing the methods required by the analyzer, and also some changes to make the methods compatible for both detector and analyzer.
The changes here will make more sense when viewed in conjunction with the corresponding integrations PR.
Checklist:
make test-community)?make lintthis requires golangci-lint)?