Skip to content

Conversation

@waketzheng
Copy link
Contributor

@waketzheng waketzheng commented Dec 26, 2025

Description

Fixes #2049

Motivation and Context

If TYPE_CHECKING, import 'Self' from typing when python>=3.11, otherwise from typing-extensions

How Has This Been Tested?

make ci

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 26, 2025

CodSpeed Performance Report

Merging #2051 will not alter performance

Comparing waketzheng:no-typing-extensions (7aa8ae3) with develop (1d2400b)

Summary

✅ 16 untouched

@coveralls
Copy link

coveralls commented Dec 28, 2025

Pull Request Test Coverage Report for Build 20611913692

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 90.743%

Totals Coverage Status
Change from base Build 20588671038: -0.001%
Covered Lines: 6634
Relevant Lines: 7196

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Self' in python standard library typing.py, but tortoise/model.py required it in 'typing_extensions'

2 participants