test(usb): create usb.Controller interface for testing#5110
Open
mikesmitty wants to merge 5 commits intotinygo-org:devfrom
Open
test(usb): create usb.Controller interface for testing#5110mikesmitty wants to merge 5 commits intotinygo-org:devfrom
mikesmitty wants to merge 5 commits intotinygo-org:devfrom
Conversation
0ce6776 to
7fc576b
Compare
Member
|
@mikesmitty can you please resolve merge conflicts so I can help review. Thank you! |
7fc576b to
64281df
Compare
Contributor
Author
|
I pushed up some changes to make it compatible with the change to disable USB-CDC when -serial=(uart|rtt), but the relevant nrf52840 code for example is still broken in this one. Now that the base is updated with the CSW fixes I'm back to working on that portion again though. Since this depends on changes to the nrf52840 and samd usb stacks those will need to be fixed before this one can be merged, but I'll be using this branch as the base for them for testing/debugging |
320364b to
3e62c8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mentioned this in a comment on #5109, this is a small refactor of the machine and usb package interactions (and some other changes mixed in that will be created as separate PRs and rebased later on). This creates a usb.Controller interface for use in the USB-related packages for mocking in unit testing and updates machine.USBDev to implement it: