fix: update generated code for @effect/platform compatibility#86
Open
kevinmichaelchen wants to merge 1 commit intotim-smart:mainfrom
Open
fix: update generated code for @effect/platform compatibility#86kevinmichaelchen wants to merge 1 commit intotim-smart:mainfrom
kevinmichaelchen wants to merge 1 commit intotim-smart:mainfrom
Conversation
- Add Scope.Scope to Effect return types in generated interfaces - Add Scope import to generated client code - Rename bodyFormDataRecord to bodyFormData (API changed in @effect/platform) These changes fix TypeScript errors when using the generated clients with recent versions of @effect/platform where HttpClient.execute returns an Effect that requires Scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope.Scopeto Effect return types in generated client interfacesScopeimport to generated client codebodyFormDataRecordtobodyFormData(API renamed in @effect/platform)Problem
When using the generated clients with recent versions of
@effect/platform(0.77+), TypeScript throws errors because:HttpClient.execute()now returnsEffect<A, E, Scope>instead ofEffect<A, E, never>HttpClientRequest.bodyFormDataRecordwas renamed tobodyFormDataExample error:
Changes
Generated interface return types
Before:
After:
Generated imports
Added:
Form data method
Changed from
bodyFormDataRecordtobodyFormData.Test plan
@effect/platform@0.77.7