fix: temporary cast to fix OpenAPISpecPathItem#80
Open
petewins wants to merge 2 commits intotim-smart:mainfrom
Open
fix: temporary cast to fix OpenAPISpecPathItem#80petewins wants to merge 2 commits intotim-smart:mainfrom
petewins wants to merge 2 commits intotim-smart:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The OpenAPI generator was not processing parameters defined at the path level in OpenAPI specifications. According to the OpenAPI 3.0 specification, parameters can be defined at the path level and are inherited by all operations under that path.
Related Issue
This addresses the upstream type issue documented in Effect-TS/effect#5760, where
OpenAPISpecPathItemdoesn't include theparametersfield that is part of the OpenAPI spec.Changes
Modified
src/OpenApi.ts:parametersfield inOpenAPISpecPathItemtype definitionExample
For an OpenAPI spec like:
Before: The getHelloWorld method would only include the uuid path parameter, ignoring
fooandbar.After: The generated method correctly includes all parameters: