This repository was archived by the owner on Apr 23, 2021. It is now read-only.
Update CMakeLists.txt for shared library build#129
Open
stephenneuendorffer wants to merge 1 commit intotensorflow:masterfrom
Open
Update CMakeLists.txt for shared library build#129stephenneuendorffer wants to merge 1 commit intotensorflow:masterfrom
stephenneuendorffer wants to merge 1 commit intotensorflow:masterfrom
Conversation
Collaborator
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
There are several circular dependencies between libraries. These are explicitly marked as STATIC. Note that add_llvm_library is redundant with add_dependencies, so we don't have to have libraries in both places.
5a0016c to
6beae9b
Compare
Member
|
Hey Stephen, Could you verify if you've signed the CLA? Thanks, Jacques |
48dcae0 to
3722f03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several circular dependencies between libraries. These
are explicitly marked as STATIC. Note that add_llvm_library is redundant
with add_dependencies, so we don't have to have libraries in both places.