feat: produce deprecation when use activity method without the activity attribute#677
Merged
feat: produce deprecation when use activity method without the activity attribute#677
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
should it be fully disabled in 3.0? |
wolfy-j
approved these changes
Feb 22, 2026
xepozz
added a commit
that referenced
this pull request
Feb 25, 2026
…ty attribute (#677) * feat: produce deprecation when use activity method without the activity attribute * feat: add feature flag * fix: make psalm pass * fix: update baseline
xepozz
added a commit
that referenced
this pull request
Mar 3, 2026
* feat: produce deprecation when use activity method without the activity attribute (#677) * feat: produce deprecation when use activity method without the activity attribute * feat: add feature flag * fix: make psalm pass * fix: update baseline * feat: Make search attribute type more lenient when parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ty attribute
What was changed
calling activity without an explicit attribute will produce E_USER_DEPRECATION warning
Why?
Checklist
Closes [Bug] Methods without ActivityMethod attribute are registered as Activities (even magic) #382
How was this tested: