fix: add bigTransactionTimeout and retryOnDeadlock to delete operations#2678
Open
dkindlund wants to merge 1 commit intoteableio:developfrom
Open
fix: add bigTransactionTimeout and retryOnDeadlock to delete operations#2678dkindlund wants to merge 1 commit intoteableio:developfrom
dkindlund wants to merge 1 commit intoteableio:developfrom
Conversation
deleteRecord and deleteRecords in RecordDeleteService use $tx but with the default Prisma transaction timeout (5s) and no deadlock retry. With FOR UPDATE locking in the computed orchestrator, delete operations can deadlock with concurrent updates touching the same records. Large batch deletes with cascading link changes can also exceed the 5s default timeout. This is inconsistent with updateRecords and multipleCreateRecords which both use bigTransactionTimeout and @retryOnDeadlock. This fix: - Adds @retryOnDeadlock() to deleteRecord and deleteRecords in RecordOpenApiService - Injects ThresholdConfig into RecordDeleteService - Passes bigTransactionTimeout to the $tx call in deleteRecords Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
deleteRecordanddeleteRecordsuse$txbut with the default Prisma transaction timeout (5s) and no deadlock retry. With FOR UPDATE locking in the computed orchestrator, delete operations can deadlock with concurrent updates touching the same records. Large batch deletes with cascading link changes can also exceed the 5s default timeout.This is inconsistent with
updateRecordsandmultipleCreateRecordswhich both usebigTransactionTimeoutand@retryOnDeadlock.What This Fix Does
@retryOnDeadlock()todeleteRecordanddeleteRecordsinRecordOpenApiServiceThresholdConfigintoRecordDeleteServicebigTransactionTimeoutto the$txcall indeleteRecordsClient Information
Platform
Docker standalone (Google Cloud Run)