[CSBindings] Disambiguate Sendable and non-Sendable function type bindings #85986
+112
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sertion methods New `introduceBinding` method encapsulates all the checking and calls `addBinding` variants to actually insert the binding into the set when required.
…dings If the type variable prefers subtypes, diasambiguate a situation when this type variable is simultaneously a supertype of `@Sendable` function type and a subtype of a non-Sendable one by using a supertype binding because it constitutes a "subtype" in this case. For example: ``` @sendable () -> Void conv $T $T argument conv () -> Void ``` Either of the types could also be wrapped in a number of optionals. Even if there is an optionality mismatch, let's still prefer a supertype binding because that would be easier to diagnose. In particular, this is helpful with ternary operators where the context is non-Sendable, but one or both sides are. Resolves: rdar://125948508 Resolves: rdar://136315240
Contributor
Author
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the type variable prefers subtypes, diasambiguate a situation
when this type variable is simultaneously a supertype of
@Sendablefunction type and a subtype of a non-Sendable one by using a supertype
binding because it constitutes a "subtype" in this case.
For example:
Either of the types could also be wrapped in a number of optionals. Even if
there is an optionality mismatch, let's still prefer a supertype binding
because that would be easier to diagnose.
In particular, this is helpful with ternary operators where the context is
non-Sendable, but one or both sides are.
Resolves: rdar://125948508
Resolves: rdar://136315240